Stake Deposit w/ Delegation Implementation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apbendi
requested review from
alexkeating and
wildmolasses
and removed request for
alexkeating
alexkeating
reviewed
Dec 12, 2023
apbendi
force-pushed
the
stake-delegation
branch
from
efbca23
to
f5b85b6
Compare
alexkeating
approved these changes
Dec 13, 2023
apbendi
force-pushed
the
stake-delegation
branch
from
bad5095
to
e63e24d
Compare
|
Coverage after merging stake-delegation into main will be
Coverage Report
|
|||||||||||||||||||
wildmolasses
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the UniStake contract and begins the implementation of the
stakemethod. Specifically, it allows a user to call stake defining an amount and a delegatee who should receive the depositor's voting weight. The contract conditionally deploys a surrogate contract for the delegatee and transfers the tokens to it.Intentionally left out of this PR—for the sake of keeping it small and reviewable—is virtually all other mechanics associated with staking, including:
All of this functionality will be implemented in subsequent PRs.